lib: introduce support for BOX records with header type6
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlrivasp
force-pushed
the
dev/box_hdr_type6
branch
from
a92c566 to
0aa74d4
Compare
psurply
requested changes
May 5, 2025
lib/src/record.rs
Outdated
| } | ||
|
|
||
| impl Record { | ||
| pub fn update_inherited_header(&mut self, inherited_header: Option<InheritedHeader>) { |
There was a problem hiding this comment.
Can we limit the visibility of this method to the crate (pub(crate))? I don't see a need to add this to the public API.
Also, since the fields of the struct are public, there is no real reason to encapsulate this logic in a method.
jlrivasp
force-pushed
the
dev/box_hdr_type6
branch
from
0aa74d4 to
6cd4530
Compare
psurply
reviewed
May 6, 2025
lib/src/region.rs
Outdated
| @@ -35,6 +35,13 @@ impl Region { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn update_socket_and_die(&mut self, socket_id: u8, die_id: u8) { | |||
There was a problem hiding this comment.
Perhaps we can call this function set_socket_and_die_ids() instead
lib/tests/record.rs
Outdated
| let record = Record { | ||
| header, | ||
| data, | ||
| ..Record::default() |
This patch includes decoding support for any box record type with a header type6. When a box record contains other records, these records inherit some values from the box header, one example is the presence of `die_id` and `socket_id` which are part of header type6. Signed-off-by: Rivas Paz, Jose L <jose.l.rivas.paz@intel.com>
jlrivasp
force-pushed
the
dev/box_hdr_type6
branch
from
6cd4530 to
f4e3b5c
Compare
psurply
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes decoding support for any box record type with a header type6. When a box record contains other records, these records inherit some values from the box header, one example is the presence of
die_idandsocket_idwhich are part of header type6.